[Ffmpeg-devel] [PATCH] h264 chroma invalid access

Michael Niedermayer michaelni
Thu Mar 29 20:32:47 CEST 2007


H

On Mon, Mar 26, 2007 at 04:05:59PM +0200, Sam Hocevar wrote:
>    Please someone more familiar with h264.c review this patch.
> 
>    The problem is that the h264_chroma_mc8_* functions need 9 lines, not
> 8, so if full_my+16 == pic_height+extra_height the chroma_op() call will
> try to read one extra line after the end of the chroma plane, resulting
> in an access violation.

patch is unacceptable due to slowdown, find a different solution

the condition you describe can only happen with my&7=0 in which case the 
8th line is not used, that is it is read and thrown away ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070329/0d2c5487/attachment.pgp>



More information about the ffmpeg-devel mailing list