[Ffmpeg-devel] [PATCH] Remove exit() in vhooks

Michael Niedermayer michaelni
Sat Mar 31 00:41:43 CEST 2007


Hi

On Thu, Mar 29, 2007 at 09:50:53PM -0400, Rich Felker wrote:
> On Fri, Mar 30, 2007 at 12:17:09AM +0200, Michael Niedermayer wrote:
> > i
> > 
> > On Thu, Mar 29, 2007 at 11:46:07PM +0200, V?ctor Paesa wrote:
> > > Hi,
> > > 
> > > The attached patch substitutes in vhooks the now forbidden exit() by return.
> > > 
> > > There is a legitimate usage of exit() in ppm.c (it ends life of a spawned
> > > process) that I have substituted by _exit(), I don't know a more elegant way
> > > of doing it.
> > 
> > #undef exit ?
> 
> For a forked child process, _exit() is the correct way to exit.
> Calling exit() in this case is very bad because it could corrupt any
> stdio files that were not flushed by the parent before forking.

yes iam a retard ...

anyway you may apply the patch, split in 2 of ideally exit()->_exit() bugfix
 and exit() -> return *

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070331/fd920c5a/attachment.pgp>



More information about the ffmpeg-devel mailing list