[Ffmpeg-devel] [PATCH] dct-test simplify test architecture

[Michael Niedermayer]

Hi

On Fri, Mar 30, 2007 at 10:05:22PM -0400, Marc Hoffman wrote:
Content-Description: message body text
> Marc Hoffman writes:
>  > Michael Niedermayer writes:
>  >  > Hi
>  >  > >  > > svn ci -m'dct-test platform independent restructure and code simplification'
>  > Done!
>  > 
>  > Please review and bless this contribution.
> 
> Forgot the emms_c, long story which is irrelevant, please review this
> one and ignore the last one.

[...]
> @@ -41,21 +42,82 @@
>  
>  #undef printf
>  
> +
>  void *fast_memcpy(void *a, const void *b, size_t c){return memcpy(a,b,c);};

cosmetic


>  
>  /* reference fdct/idct */
> +extern void init_fdct();
>  extern void fdct(DCTELEM *block);
>  extern void idct(DCTELEM *block);
> +extern void j_rev_dct(DCTELEM *data);
> +extern void odivx_idct_c (short *block);
> +
> +#ifdef ARCH_X86
>  extern void ff_idct_xvid_mmx(DCTELEM *block);
>  extern void ff_idct_xvid_mmx2(DCTELEM *block);
> -extern void init_fdct();
> -
> -extern void j_rev_dct(DCTELEM *data);
>  extern void ff_mmx_idct(DCTELEM *data);
>  extern void ff_mmxext_idct(DCTELEM *data);
> +#endif

the ifdef is senseless


[...]
>                  block[idct_mmx_perm[i]] = block1[i];
> -        } else if(fdct_func == ff_simple_idct_mmx ) {
> +            } else if (form == MMX_SIMPLE_PERM) {
>              for(i=0;i<64;i++)

trashed indention


[...]
> -    emms();
> +    emms_c();

this bugfix could be in a seperate patch


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070331/d2e98438/attachment.pgp>