[Ffmpeg-devel] [PATCH] cosmetics and minor bugfix to True Audio Demuxer

Masahiro Kiyota hiro3726
Sat Mar 31 14:49:38 CEST 2007


2007/3/31, Diego Biurrun <diego at biurrun.de>:
> On Sat, Mar 31, 2007 at 08:16:41PM +0900, Masahiro Kiyota wrote:

> > @@ -109,7 +111,7 @@ static int tta_read_packet(AVFormatConte
> >
> >      // FIXME!
> > -    if (c->currentframe > c->totalframes)
> > +    if (c->currentframe >= c->totalframes)
>
> What's the problem here and why the FIXME?

c->currentframe must be between 0 and totalframes although it doesn't
segfault and looks okay.
Actually, when c->currentframe == c->totalframes,
c->seektable[c->currentframe] is out of range.

see line 78:
c->seektable = av_mallocz(sizeof(uint32_t)*c->totalframes);


It is not me but someone else who wrote "FIXME".
So I don't know why.




More information about the ffmpeg-devel mailing list