[Ffmpeg-devel] Re: [PATCH] Fix compilation when using --disable-opts

Alexis Ballier alexis.ballier
Sat Mar 31 21:34:39 CEST 2007


> > #if defined(ARCH_X86_64) || (defined(ARCH_X86_32) &&
> > defined(CONFIG_EBX_AVAILABLE) && defined(CONFIG_EBP_AVAILABLE))
> > #  define CONFIG_7REGS 1
> > #endif
> >
> > shouldn't this also add && !defined(PIC) ?
>
> maybe

what I meant there was : since PIC is supposed to eat one register, do
we really have 7 registrers when compiling with PIC ?
I dont think I understand what this patch was fixing and how, so I
cannot help much more.
But previously there was no compile problem and it was under a !(PIC
&& __GNUC__) guard.


> the patch attached to that bug report
> http://bugs.gentoo.org/attachment.cgi?id=115012 is mega turbo wrong.
> Removing the PIC register from the clobber list is obviously wrong: it
> will compile, but produce corrupt data.


Yep, what I feared :/ (but I didnt know what it would imply) thanks
for confirming this


-- 
Alexis Ballier.




More information about the ffmpeg-devel mailing list