[FFmpeg-devel] [PATCH] configure: x11grab + ld --as-needed

[Pavlov Konstantin]

On Thu, May 03, 2007 at 02:14:18PM +0200, Diego Biurrun wrote:

> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -1729,7 +1729,8 @@ check_header X11/Xlib.h                 &&
> > > >  check_header X11/extensions/XShm.h      &&
> > > >  check_func XOpenDisplay -lX11           &&
> > > >  check_func XShmCreateImage -lX11 -lXext &&
> > > > -add_extralibs -lX11 -lXext              ||
> > > > +add_extralibs -lX11 -lXext              &&
> > > > +enable x11_grab                         ||
> > > >  disable x11_grab_device_demuxer
> > > 
> > > Looks wrong, what's the problem you're trying to address there?
> > 
> > Only adding x11_grab variable to be used in configure output.
> 
> That variable already exists and is already being set ..

$x11grab exists. It's set with --enable-x11grab.
If some of check_header/check_func fail, it stays in 'yes' state, while
x11_grab_device_demuxer is 'no'.

So i thought it should be ok to add another variable showing status of
those checks. Maybe it's better to disable x11grab after disable
x11_grab_device_demuxer as well.

> > > > @@ -1833,6 +1834,7 @@ echo "static                    $static"
> > > >  echo "shared                    $shared"
> > > >  echo "postprocessing support    $pp"
> > > >  echo "software scaler enabled   $swscaler"
> > > > +echo "x11 grabbing enabled      $x11_grab"
> > > >  echo "video hooking             $vhook"
> > > 
> > > I don't really like this.  We have a list of things that we print info
> > > about.  You could argue that it's arbitrary, adding things here and
> > > there is not going to help (much).
> > 
> > I think it's actually a good idea to print out useful info about configure
> > results. Especially when it comes to something i explicitly --enable.
> > Could be done with $x11_grab_device_demuxer though.
> 
> I'm not claiming you don't have a point, just that we should look into a
> slightly more general solution in the medium term.

Right.

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070503/67ae2e82/attachment.pgp>