[FFmpeg-devel] [PATCH] add dca and vc1 objects to Makefile when parsers are enabled
Fri May 4 02:00:15 CEST 2007
On Thu, May 03, 2007 at 08:38:24PM +0300, Kostya wrote:
> On Thu, May 03, 2007 at 06:06:17PM +0200, Diego Biurrun wrote:
> > On Thu, May 03, 2007 at 12:07:56PM +0200, Michael Niedermayer wrote:
> > >
> > > On Thu, May 03, 2007 at 11:54:56AM +0200, Diego Biurrun wrote:
> > > > On Thu, May 03, 2007 at 09:28:57AM +0200, Benoit Fouet wrote:
> > > > >
> > > > > seen on ffmpeg user mailing list
> > > > > when disabling en/decoders, those two objects are not built even though
> > > > > they are needed to parse
> > > >
> > > > The patch is OK, but I think it would be better to put the dca and vc1
> > > > parser code in parser.c along with the rest of the parsers. The parser
> > > > code is a very small part of both decoders.
> > >
> > > _all_ parsers should be put in seperate files. putting them in parser.c
> > > is an extreemly ugly hack and while i agreed for ac3 as noone was willing
> > > to solve that properly i will NOT agree to move the other parsers to the
> > > wrong file too!
> > So let's start. Here is a patch that moves the dca parser to its own file.
> > I have named it dca_parser.c. That looks like a sane naming scheme to
> > me. I have created dca.h and dca_parser.c with svn cp in my local tree
> > but I have diffed them against /dev/null to send here, multithousand
> > line patches are not particularly easy to read.
> I have no objections against this nor vc1_parser done this way.
> Apply anytime. If I had enough time I could do it myself.
Applied. vc1_parser.c on its way.
More information about the ffmpeg-devel