[FFmpeg-devel] PATCH BlackFin YUV2 to RGB Color Space Converters

Marc Hoffman mmh
Sat May 5 12:02:34 CEST 2007


Rich Felker writes:
 > On Sat, May 05, 2007 at 04:50:50AM -0400, Marc Hoffman wrote:
 > > Hi,
 > > 
 > > Luca Barbato writes:
 > >  > Marc Hoffman wrote:
 > >  > > Blackfin optimized YUV420 to RGB CSC Color Space Converters.
 > >  > 
 > >  > > Please review thank you.
 > >  > 
 > >  > > +#define clock()      ({ int _t; asm volatile ("%0=cycles;" : "=d" (_t)); _t; })
 > >  > 
 > >  > why _t?
 > > 
 > > I used it in the code to verify I got the same values as what you get
 > > with utime.  It's not even used good catch I will remove it.
 > 
 > Use a function (inline) instead to avoid the nasty gcc-ism and the
 > need for a variable name that doesn't clash.
 > 

I removed the functionality, but I will make note of your suggestion in other places.

Thanks for the tip.

Marc




More information about the ffmpeg-devel mailing list