[FFmpeg-devel] [PATCH] move mpeg4video_parser in it's own file
Sat May 5 19:20:56 CEST 2007
On Sat, 5 May 2007 18:46:14 +0200
Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, May 05, 2007 at 06:30:02PM +0200, Aurelien Jacobs wrote:
> > Here is a patch to move mpeg4video_parser into it's own .c file.
> > Oviously, mpeg4video_parser.c is a svn cp of parser.c.
> > Ok to commit ?
> > --- libavcodec/mpeg4video_parser.c (revision 8895)
> > +++ libavcodec/mpeg4video_parser.c (working copy)
> > @@ -19,287 +19,12 @@
> > #include "avcodec.h"
> > #include "mpegvideo.h"
> > -#include "mpegaudio.h"
> > #include "parser.h"
> You don't need all those headers, just parser.h and dsputil.h is
> probably enough.
parser.h is obviously needed.
mpegvideo.h is also needed (usage of MpegEncContext, etc...).
avcodec.h is also needed (for AVCodecContext) but it's also needed
by parser.h, so I think it should be included in parser.h instead.
(see attached patch)
> That parser.h depends on dsputil.h being included beforehand is an
> uglyness that should be fixed. IMO headers should directly include
> everything they need.
Agree with this.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 316 bytes
Desc: not available
More information about the ffmpeg-devel