[FFmpeg-devel] PATCH Blackfin DSP utilities, DEFUN_END added
Sun May 6 04:53:09 CEST 2007
Michael Niedermayer writes:
> On Sat, May 05, 2007 at 06:26:07AM -0400, Marc Hoffman wrote:
> Content-Description: message body text
> > The defun end macro adds the size information to the symbol
> > table. This is to keep things consistent and help the
> > loader/debugger.
> could you elaborate on "helps" does it fail without that or what?
> also the patch is full of cosmetics
It's the correct way of representing the assembler modules, a
colleague of mine pointed out that this should be required for the
1. if you dont add the STT_FUNC, then the ELF symbol is not declared
as a function, it shows up as "NOTYPE"
2. If you don't have the size then the symbol is set automagically
based on the next symbol found which may not be correct.
The code still functions correctly this is a cosmetic change which is
only for debugging and such.
The white space additions were needed to clean up the code when adding
the DEFUN_END otherwise it made it harder to see the end of the
No functionality changes with this patch.
More information about the ffmpeg-devel