[FFmpeg-devel] [PATCH] Fix compilation when only MPEG-1encoder is enabled

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Aurelien,


Aurelien Jacobs wrote:
> On Thu, 10 May 2007 13:34:53 +0200
> Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
> 
>> Hi,
>>
>> The mpegvideo.c file unconditionally refers to code in the wmv2.c file.
>> As mpegvideo.c is compiled unconditionally, the attached patch removes
>> these references if wmv2 encoder support is not being compiled.
>>
>> When compiling ffmpeg code configured with the following options:
>> ./configure --disable-encoders --enable-encoder=mpeg1video
>>
>> Compilation was currently broken, and fixed with this patch.
> 
> I'm currently in the process of fixing this. I might do it a different
> way. 

I'm curiously awaiting it :) I could only think of compiling it all in,
or making sure mpegvideo.c doesn't reference it when it isn't available.
Unless of course your making bigger changes in mpegvideo.c, making the
ff_wmv_* code generic and adding it to some commonly compiled code, I
can't see a quick solution...


> Note that there are much more references to mpeg4/wmv2 which needs
> to be disabled.

Weird, the patch worked fine here. For other configurations, such as
with all decoders disabled there seems to be one other reference to a
wmv2 decoding related function (line 4080 in mpegvideo.c) which would
cause problems.

I didn't get any references to mpeg4 code which was unavailable though,
I thought your recent patches fixed this.

> So please don't commit this.

No problem.


> I should be able to fix it today.

Excellent :-)


With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGQwla9kOxLuzz4CkRAmffAJ9jWljuzNwZly0kHhXFv/x6Hnl/mQCdGC4g
GrQdOuJE+6tj1ucXYX1AR+g=
=qvxR
-----END PGP SIGNATURE-----