[FFmpeg-devel] [PATCH] Make vp3dsp*.c compilation optional

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

The attached patch tries to make the vp3dsp*.c compilation optional.
Again, not meant for direct inclusion, as I am not sure about the
correctness... I am a bit confused about Theora decoding:

In dsputil_init() it seems ff_vp3_idct_* functions are being used to
decode Theora:
    3886         }else if(avctx->idct_algo==FF_IDCT_VP3){
    3887             c->idct_put= ff_vp3_idct_put_c;
    3888             c->idct_add= ff_vp3_idct_add_c;
    3889             c->idct    = ff_vp3_idct_c;
    3890             c->idct_permutation_type= FF_NO_IDCT_PERM;


While in dsputil_init_mmx() it seems they are explicitly avoided for
decoding Theora:
    3282             }else if(idct_algo==FF_IDCT_VP3 &&
    3283                      avctx->codec->id!=CODEC_ID_THEORA &&
    3284                      !(avctx->flags & CODEC_FLAG_BITEXACT)){
    3285                 if(mm_flags & MM_SSE2){
    3286                     c->idct_put= ff_vp3_idct_put_sse2;
    3287                     c->idct_add= ff_vp3_idct_add_sse2;
    3288                     c->idct    = ff_vp3_idct_sse2;
    3289                     c->idct_permutation_type=
FF_TRANSPOSE_IDCT_PERM;
    3290                 }else{

Is something fishy or am I just misinterpreting the code?

The attached patch assumes the current code mentioned above is correct.

 Makefile           |   15 ++++++++-------
 dsputil.c          |    3 ++-
 i386/dsputil_mmx.c |    3 ++-
 3 files changed, 12 insertions(+), 9 deletions(-)

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGSFWY9kOxLuzz4CkRAqzXAJ43O2G9P4YiqP8mZBQilMe7ynp1KACfSHvg
dXnm3d7Ch5BIUKEMzhDCcOk=
=StOu
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070514T141319-ffmpeg-optional_vp3dsp_compilation.diff
Type: text/x-patch
Size: 3923 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070514/ac422dda/attachment.bin>