[FFmpeg-devel] [PATCH] Make golomb.c compilation optional

Måns Rullgård mans
Mon May 21 17:14:24 CEST 2007


Panagiotis Issaris wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> Aurelien Jacobs wrote:
>> On Mon, 21 May 2007 15:45:04 +0200
>> Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
>>
>>> Hi,
>>>
>>> The attached patch makes sure golomb.c is only compiled when needed.
>>>
>>> When disabling all codecs for which I explicitly enabled the golomb.o
>>> dependency, all compiled fine without unresolved symbols:
>>> ./configure --disable-decoder=h264 --disable-encoder=sonic_ls
>>> - --disable-decoder=sonic --disable-encoder=sonic
>>> - --disable-decoder=shorten --disable-decoder=svq3
>>> - --disable-encoder=jpegls --disable-decoder=jpegls --disable-decoder=loco
>>> - --disable-decoder=cavs --disable-decoder=ffv1 --disable-decoder=flac
>>> - --disable-encoder=flac
>>>
>>> I obviously tried other configurations as well (such as a plain
>>> ./configure and some subsets of the above mentioned flags).
>>>
>>>
>>>  Makefile |   25 ++++++++++++-------------
>>>  1 file changed, 12 insertions(+), 13 deletions(-)
>>
>> Patch ok.
>
> Is it okay to apply, or should I wait for the ones specified as
> maintainers for this file to confirm it (those being Diego and M?ns)?

Go ahead and apply.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list