[FFmpeg-devel] [PATCH] libavformat/mpegts.c minor crash and warning avoidance

[Benoit Fouet]

Hi,

Glenn A. Serre wrote:
> Good afternoon,
>
> Benoit Fouet wrote:
>   
>> Hi,
>>
>> Glenn A. Serre wrote:
>>     
>>> Good evening,
>>>
>>> This patch would be to avoid a compiler warning and avoid a crash that 
>>> happened when I experimented with having mpegts add streams from all the 
>>> PMTs in the transport stream, rather than just from the first one found.
>>>
>>>   
>>>       
>> it is better to split patches
>> the two ones you're proposing are not correlated, so they should be
>> splitted.
>>     
>
> OK.  What is protocol in these cases?  Should I reply with two 
> attachments, make two replies, or ???
>
>   

i think it is ok if you reply with two patches, now that the thread exists

>>> Please note that I can't actually check this in (or at least I shouldn't 
>>>   be able to).  Also, please note that the revision number below is 
>>> against our repository, not the official ffmpeg one.
>>>
>>>   
>>>       
>> but it is not against svn head, so your patch cannot be applied as is
>>
>>     
> [...]
>
> The diff was against a file imported from yesterdsy's head, and it does 
> apply to the current svn head
> (using patch -i ~/tmp/patch.txt libavformat/mpegts.c), but I'll resend 
> svn diffs in the actual ffmpeg svn tree.
>
>   

in this case, send the patch as a file, instead of inlining it, it
should do it

Ben
-- 
Purple Labs S.A.
www.purplelabs.com