[FFmpeg-devel] [PATCH] libavformat/mpegts.c minor crash and warning avoidance

[Michael Niedermayer]

Hi

On Fri, May 25, 2007 at 09:50:23PM -0700, Glenn A. Serre wrote:
> Good evening,
> 
> Benoit Fouet wrote:
> >Hi,
> >
> >Glenn A. Serre wrote:
> >>Good afternoon,
> >>
> >>Benoit Fouet wrote:
> >>  
> >>>Hi,
> >>>
> >>>Glenn A. Serre wrote:
> >>>    
> >>>>Good evening,
> >>>>
> >>>>This patch would be to avoid a compiler warning and avoid a crash that 
> >>>>happened when I experimented with having mpegts add streams from all 
> >>>>the PMTs in the transport stream, rather than just from the first one 
> >>>>found.
> >>>>
> >>>>  
> >>>>      
> >>>it is better to split patches
> >>>the two ones you're proposing are not correlated, so they should be
> >>>splitted.
> >>>    
> >>OK.  What is protocol in these cases?  Should I reply with two 
> >>attachments, make two replies, or ???
> >>
> >>  
> >
> >i think it is ok if you reply with two patches, now that the thread exists
> >
> [...]
> 
> Sorry for the delay.  The two separate patches are attached.

the second patch is rejected
at least until you provide everyting needed to reproduce the crash and an
analysis of why the crash happens, from my POV this looks like your
private modifications are buggy and causing it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070526/72851bbc/attachment.pgp>