[FFmpeg-devel] [PATCH] RoQ video decoder split

Benoit Fouet benoit.fouet
Tue May 29 17:03:00 CEST 2007


Michael Niedermayer wrote:
> Hi
>
> On Tue, May 29, 2007 at 03:18:04PM +0200, Vitor wrote:
>   
>> Benoit Fouet wrote:
>>     
>>> [...]
>>> as no log message was provided, applied with the following one:
>>> cosmetics and function rename
>>>
>>> Ben
>>>  
>>>       
>> To give sequence to the RoQ encoder inclusion, I'm sending a patch to 
>> split roqvideo.c in roqvideo.c/roqvideo.h/roqvideodec.c. Actually, I'm 
>> not sure if the way I made the diffs is the preferred one when splitting 
>> files.
>>     
>
> the diffs are ok
>
>
>   

with a rename of the firts line for copied files, it would have been
perfect ;)

>> If it is committed, I suggest the log message "Split RoQ decoder to 
>> accommodate future encoder patch".
>>     
>
> patch looks ok
>
> [...]
>
>   

applied with suggested log message

Ben
-- 
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list