[FFmpeg-devel] [PATCH] Doxygenate libavutil/mem.h

[Michael Niedermayer]

On Fri, Nov 02, 2007 at 05:11:24PM +0100, Stefano Sabatini wrote:
> On date Friday 2007-11-02 15:55:25 +0100, Michael Niedermayer encoded:
> > On Thu, Nov 01, 2007 at 09:25:11PM +0100, Stefano Sabatini wrote:
> [...]
> > > Thanks for your review, hope now it is more correct.
> > 
> > looks ok
> 
> AAAARGH, where did I left my head!!
> 
> /**
> - * Free memory and set the pointer to NULL.
> - * @param ptr Pointer to the pointer which should be freed.
> + * Free a memory block which has been allocated with av_malloc(z)() or
> + * av_realloc() and set to NULL the pointer to it.
> + * @param ptr Pointer to the pointer to the memory block which should
> + * be freed.
> + * @note ptr = NULL is explicitly allowed.
>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> wrong since it will cause NULL pointer dereference in the code.
> 
> New patch and new personal record in subsequently sent wrong patches
> ;-).

new patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071102/4b167fd8/attachment.pgp>