[FFmpeg-devel] [PATCH] Fix swapped colours for RGB555 and RGB565 in swscale

Diego Biurrun diego
Sun Nov 4 02:48:37 CET 2007

On Sun, Oct 28, 2007 at 12:12:08AM +0200, Michael Niedermayer wrote:
> On Wed, Oct 24, 2007 at 03:48:00PM +0300, Kostya wrote:
> > Looks like rgb1[56]toUV have color values swapped.
> > Fixes roundup issue 162 and reported problem with 15-bit TSCC files.
> this patch is TOTALLY wrong
> it changes rgb1[56]toUV so they become identical to bgr1[56]toUV and at the
> same time results in the corresponding luma functions to mismatch
> which means that after this the output is _really_ wrong while before it
> was merely switching red and blue
> the actual bug seems to be that the function names of [rgb|bgr]1[56]to[UV|Y]
> should be rgb<->bgr flipped

So OK to apply the attached patch which renames the functions?  I tested
it, the colors are correct with the patch applied.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: swap_names.diff
Type: text/x-diff
Size: 2317 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071104/897deba2/attachment.diff>

More information about the ffmpeg-devel mailing list