[FFmpeg-devel] [PATCH] Fix some warnings in nut.c

[Michael Niedermayer]

On Sun, Nov 04, 2007 at 02:10:18PM +0100, Diego Biurrun wrote:
> OK to apply the attached patch for
> 
> nut.c: In function ?ff_nut_sp_pos_cmp?:
> nut.c:43: warning: suggest parentheses around + or - inside shift
> nut.c:43: warning: suggest parentheses around + or - inside shift
> nut.c: In function ?ff_nut_sp_pts_cmp?:
> nut.c:47: warning: suggest parentheses around + or - inside shift
> nut.c:47: warning: suggest parentheses around + or - inside shift
> 
> ?

darn no! ive rejected this at least once already
this is no warning fix it is just _WRONG_ the code just doesnt
work anymore after this patch!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071104/fcadca5f/attachment.pgp>