[FFmpeg-devel] [PATCH 0/6] split out functions in rmdec.c

Ronald S. Bultje rsbultje
Mon Nov 5 21:19:32 CET 2007


here's some function split-outs in rmdec.c. The goal here is to isolate some
parsing functionality that can be reused by the RDT (realmedia/rtsp) reader
without having to duplicate that code. Specifically, frame parsing and MDPR
header parsing can be shared, as well as ac3 byte swapping and the cacahed
data retrieval (for audio data if there's multiple frames in a single
packet). The following patches will split out these functions out of the
huge function bodies in rmdec.c into (static) new functions, I have one
patch for each of the above four. The last two functions re-arrange the ac3
byte swapping from being called in the packet parsing function into
higher-up functions such that the RDT code does not have to explicitely call
it by itself, and makes each of those functions non-static so it can access
them from rtp_rm.c (this is a separate patch that will have to be split up
further before it can be applied...).

Please let me know what you think of each.


More information about the ffmpeg-devel mailing list