[FFmpeg-devel] [PATCH 5/6] rmdec.c: move around rm_ac3_swap_bytes()

Michael Niedermayer michaelni
Fri Nov 9 04:03:48 CET 2007


On Thu, Nov 08, 2007 at 10:48:36AM -0500, Ronald S. Bultje wrote:
> Hi,
> On Nov 5, 2007 3:28 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > as mentioned in 4/6, ac3_swap_bytes() would ideally be called higher up,
> > such that the RTP parsing code does not need to call or swap bytes
> > explicitely itself. This patch does exactly that.
> Anyone want to review this one? It's the last rmdec-related one, at least
> for the function refactoring.

ill leave this one to roberto, iam not sure about it
the other changes where nice cleanup on their own so i think roberto didnt
mind me approving them :)

also i just noticed that
static int rm_


static int

is mixed in rmdec.c, this should be cleaned up, its inconsistant style
also i assume the static in the second will disapear otherwise the ff_
is wrong ..

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071109/3d73c6be/attachment.pgp>

More information about the ffmpeg-devel mailing list