[FFmpeg-devel] [Patch] Alternative OS/2 patch
Fri Nov 9 06:16:15 CET 2007
On 11/05/07 04:11 pm, Diego Biurrun wrote:
> On Mon, Nov 05, 2007 at 08:04:12AM -0800, Dave Yeo wrote:
>> On 11/04/07 04:29 pm, Diego Biurrun wrote:
>>> On Sun, Nov 04, 2007 at 02:07:54PM -0800, Dave Yeo wrote:
>>>> --- configure (revision 10924)
>>>> +++ configure (working copy)
>>>> @@ -1210,6 +1212,33 @@
>>>> + os/2)
>>>> + SLIB_CREATE_DEF_CMD="echo LIBRARY \$(FULLNAME) INITINSTANCE TERMINSTANCE > \$(FULLNAME).def; \
>>>> + echo DESCRIPTION '\"\$(SLIBNAME_WITH_VERSION)\"' >> \$(FULLNAME).def; \
>>>> + echo PROTMODE >> \$(FULLNAME).def; \
>>>> + echo CODE PRELOAD MOVEABLE DISCARDABLE >> \$(FULLNAME).def; \
>>>> + echo DATA PRELOAD MOVEABLE MULTIPLE NONSHARED >> \$(FULLNAME).def; \
>>>> + echo EXPORTS >> \$(FULLNAME).def; \
>>>> + emxexp -o \$(OBJS) >> \$(FULLNAME).def"
>>> Try using 'cat << EOF', that should simplify things a lot.
>> I've never seen cat used this way and not sure how that would work.
> Then it's high time :)
> Something like
> cat << EOF > filename
> should accomplish the above without all the nasty escaping.
While now having more understanding of here-documents it seems to only
be applicable to shell scripts and I can't see anyway to easily use it
in a makefile. The command does have to be run by the makefile to expand
the variables and we need the objects already built to extract the
exports from them.
Attached patch cleans up some of the nasty escaping by putting the
DESCRIPTION field into a separate variable. This has the extra advantage
that it makes it simpler to change the description. (adding things like
vendor or bldlevel info).
Also makes config.mak more readable :)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3550 bytes
Desc: not available
More information about the ffmpeg-devel