[FFmpeg-devel] [PATCH] Provide top_field_first logic for h264.c

Måns Rullgård mans
Fri Nov 9 10:02:34 CET 2007


Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Thu, Nov 08, 2007 at 09:22:16PM +0100, Reinhard Nissl wrote:
>> Hi,
>> 
>> the patch was last posted in the thread "H.264 + PAFF: BBC HD recording
>> shows extreme interlacing artefacts".
>> 
>> It provides top_field_first by comparing frame poc (picture order count)
>> against top field poc. When both match, the frame shall be displayed
>> with top field first.
>
> looks ok, except maybe that top_field_first would be 1 for non interlaced
> content which is a little odd to me
> i think (though havnt checked) that top_field_first is 0 for non interlaced
> content in other codecs

If the content is non-interlaced the fields should be displayed
simultaneously, so there is no field order.  If the hardware isn't
capable of this, the order chosen doesn't matter.  Hence there is no
problem with setting it to top_field_first in this case.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list