[FFmpeg-devel] [PATCH] IPv6 support v.2

Michael Niedermayer michaelni
Tue Nov 13 17:25:17 CET 2007

On Thu, Nov 08, 2007 at 09:09:42AM +0100, Luca Abeni wrote:
> Hi,
> Luca Abeni wrote:
> [...]
>> I believe that some redundant code can be removed (reworking the code
>> a little bit) without losing support for anything or changing any
>> functionality... But I have no patches yet to prove this claim.
>> I hope to send some example patches soon to clarify my idea (just give
>> me the time to test some ideas).
> And here are the patches. Lightly tested, on r10952, for both unicast and
> multicast UDP, either with or without --disable-ipv6.
> I generated the patches in a short time, so maybe some of them can have
> typos or can be written in a better way, but I believe they show how to
> remove duplicated code without (hopefully :) breaking anything.
> - address-len.diff removes some stupid ifdef by using the dest_addr_len
>   field in both the IPv4-only and the generic code. In this way, we 
> decrease
>   the differences between the two cases

looks ok

> - fix-multicast-mess.diff removes an useless field in struct UDPContext, 
> and
>   uses the same code in the IPv4-only and the generic code, renaming some
>   functions with appropriate names

split this please, at least all renames and cosmetics should be seperated

> - remove_from.diff removes some more ifdefs by using recv() instead of 
> recvfrom()
>   (the "from" parameter was discarded anyway...)

ok if it works

> - simplify-set-remote-url.diff removes some code duplictaion in 
> udp_set_remote_url()

ok if it works

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071113/b19d2ca1/attachment.pgp>

More information about the ffmpeg-devel mailing list