[FFmpeg-devel] [RFC] scenechange_score in AVCodecContext?

[Michael Niedermayer]

Hi

On Wed, Nov 14, 2007 at 03:00:55PM +0100, Stefano Sabatini wrote:
> On date Wednesday 2007-11-14 12:28:24 +0100, Michael Niedermayer encoded:
> > On Wed, Nov 14, 2007 at 11:57:41AM +0100, Stefano Sabatini wrote:
> > > On date Wednesday 2007-11-14 10:55:21 +0100, Diego Biurrun encoded:
> > > > On Wed, Nov 14, 2007 at 09:47:10AM +0100, Stefano Sabatini wrote:
> [...]
[...]
> > also in above case it should be 
> > /**
> >  * The shed color.
> > 
> > and no should, but rather
> > Values must be >= 0 and < AV_BIKE_COLORS_NB
> > 
> > also avoid the between without specifying if its inclusive/exclusive of the
> > end points
> 
> Well, if it's OK I can write a small patch to clarify all these points
> (and discuss it into another thread).
> 
> But this is also going astray from the original issue of the thread,
> so please could you comment about the attached patch?


[...]
> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 11020)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -33,8 +33,8 @@
>  #define AV_STRINGIFY(s)         AV_TOSTRING(s)
>  #define AV_TOSTRING(s) #s
>  
> -#define LIBAVCODEC_VERSION_INT  ((51<<16)+(48<<8)+0)
> -#define LIBAVCODEC_VERSION      51.48.0
> +#define LIBAVCODEC_VERSION_INT  ((51<<16)+(49<<8)+0)
> +#define LIBAVCODEC_VERSION      51.49.0
>  #define LIBAVCODEC_BUILD        LIBAVCODEC_VERSION_INT
>  
>  #define LIBAVCODEC_IDENT        "Lavc" AV_STRINGIFY(LIBAVCODEC_VERSION)
> @@ -1671,6 +1671,15 @@
>      unsigned int stream_codec_tag;
>  
>      /**
> +     * scene change score.
> +     * Measures the degree of change between the current and the
> +     * previous encoded frame.
> +     * - encoding: Set by libavcodec.
> +     * - decoding: unused
> +     */
> +    int scenechange_score;
> +
> +    /**
>       * scene change detection threshold
>       * 0 is default, larger means fewer detected scene changes.
>       * - encoding: Set by user.

you cannot add anything in the middle it breaks the ABI
also id like to see some examples where this is usefull/needed
iam not in favor of exporting stuff just because it can be exportet
there should be some sense in it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071115/7b909c40/attachment.pgp>