[FFmpeg-devel] perror() in libav*?

Michel Bardiaux mbardiaux
Thu Nov 15 14:24:59 CET 2007


Luca Abeni a ?crit :
> Hi all,
> 
> I recently noticed that some code in libavformat and libavcodec
> calls perror() on errors. I assume this is not good, and such
> code should be fixed, right?
> 
> I see two possibilities:
> 1) replace perror() with a proper call to av_log() (maybe using
>     AV_LOG_WARNING instead of AV_LOG_ERROR?)
> 2) just remove all the references to perror() and return an error
>     code (the calling application will be in charge of printing
>     something)
> 
> The third possibility is to leave everything as is is now ;-)

IMHO one needs *both* 1 and 2.

> 
> What do other people think?

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/




More information about the ffmpeg-devel mailing list