[FFmpeg-devel] MMX version for put_no_rnd_h264_chroma_mc8_c

Guillaume Poirier gpoirier
Mon Nov 19 10:12:15 CET 2007


Christophe GISQUET wrote:
> Michael Niedermayer a ?crit :
>> less code duplication is preferred unless that would cause a speed loss ...
>> if it does, i dont know, but i wont accept duplicating code without
>> someone providing benchmark scores showing its faster
> The function with rounding is located in dsputil_h264_template_mmx.c
> As a consequence, it's templated, and only one version is of interest.
> The attached patch is a demonstration of what I'm doing to allow not to
> round. I haven't thought yet on how to do it more cleanly...
> Benchmarking the old and new codes on an h264 sequence yield no difference.

Now the same without useless re-indentation.
Please try to address these kind of minor issues. They do make
reviewing a lot easier.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: h264.2.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071119/0256e6c4/attachment.asc>

More information about the ffmpeg-devel mailing list