[FFmpeg-devel] [PATCH] RV30/40 decoder

[Reimar Döffinger]

Hello,
On Sat, Nov 24, 2007 at 12:58:54PM +0100, Michael Niedermayer wrote:
> On Sun, Nov 18, 2007 at 11:11:24AM +0200, Kostya wrote:
> > Well, it roughly the same feature-wise as it was,
> > I just don't think I will improve it soon, yet
> > it is playable (and maybe will attract samples
> > and patches, I'm an optimist).
> 
> more reviewing, also your chances of seeing this applied would improve
> if you splited it in maybe 10+ patches!
> the problem is every time i look at it i find new issues but its too big
> (400k uncompressed) to really review all at once, one inevitably becomes
> tired so the quality of the review degrades and many issues are missed
> and with the next iteration another subset of the issues is found and
> so on ...

Hmm... what do you think about dumping the .h files with the tables into
SVN first? This IMO would remove a lot of irritating clutter that is
mostly unreviewable from the patch...
Also maybe then the patch is small enough so it does need to be
compressed, that discourages me immensely from having a look myself
(though I'd find it hard to review the code for a proper codec anyway).

Greetings,
Reimar D?ffinger