[FFmpeg-devel] [PATCH] split vc1dsp_mmx in its own compilation unit

Christophe GISQUET christophe.gisquet
Tue Nov 27 01:05:23 CET 2007


Aurelien Jacobs a ?crit :
> This allows disabling vc1dsp code when vc1 is disabled.
> This patch duplicates the ff_pw_3 const integer. I think it's not

+static const uint64_t ff_pw_3  attribute_used __attribute__ 
((aligned(8))) = 0x0003000300030003ULL;

Nitpicking but:
- I prefer use of macro DECLARE_ALIGNED_8/16 (though you have an 
attribute_used here)
- if it's static, then it doesn't need ff_ prefix; code throughout the 
file should be modified if you choose to perform that change

Otherwise, no objection, on the contrary, that's a good move.

Best regards,
Christophe GISQUET

More information about the ffmpeg-devel mailing list