[FFmpeg-devel] [PATCH] wma decoder return value does not fit actually used data

Michael Niedermayer michaelni
Fri Nov 30 22:15:49 CET 2007


On Fri, Nov 30, 2007 at 05:43:51PM +0100, Reimar D?ffinger wrote:
> Hello,
> currently the wma decoder always returns s->block_align, but actually it
> (tries to) use up all data in the input buffer.
> Even worse, it also returns s->block_align when the buffer size is
> smaller than that.
> There are two ways to fix it: either change the return value to return
> the size of the buffer or use s->block_align as buffer size.
> The former has the disadvantage that we would then need a separate
> AVParser (AFAICT), whereas the latter fixes the playback problems in
> both ffplay and mplayer without further changes.
> A sample file is incoming/wmabugs.wmv , which plays fine with attached
> patch.
> Does it look okay to apply to you?

well, a parser might be better (or not) its hard to say after all we
dont really have a wma spec which says how packets should look ...

so iam ok with the patch ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071130/3cf86a9d/attachment.pgp>

More information about the ffmpeg-devel mailing list