[FFmpeg-devel] [PATCH] read metadata in FLAC demuxer

Justin Ruggles justinruggles
Tue Oct 2 05:30:28 CEST 2007


Here is a new patch.  There is now very little redundancy.  The FLAC 
demuxer, Ogg-FLAC demuxer, and FLAC decoder all share a single function 
to parse the streaminfo header.  The rest of the metadata is handled 
according to the format and requirements of each.  This simplifies the 
decoder metadata parsing quite a bit and fixes related bugs.

The changes to the Ogg demuxer are shown here for demonstration purposes 
only.  The changes would be done separately, in 2 commits.  One to 
utilize the shared function and another to simplify the code.  Due to 
the dependency on the flac decoder, this maybe should wait until if/when 
a FLAC parser is implemented.

Ideally, I would like to rename flac.c to flacdec.c and put the shared 
function into a new flac.c.  As far as the build system is concerned, 
this would only be useful if there was a parser to use a dependency 
reference which is tied to the shared code, similar to how it's done 
with AC3.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-flac-demuxer-2.diff
Type: text/x-patch
Size: 14176 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071001/41d3535c/attachment.bin>

More information about the ffmpeg-devel mailing list