[FFmpeg-devel] libavutil simd

[Diego Biurrun]

On Tue, Oct 02, 2007 at 12:36:21PM +0200, Luca Barbato wrote:
> 
> here the patch, it works fine for ppc, Diego have a look at the Makefile
> changes.
> 
> check_altivec.c MUST BE BUILT w/out -maltivec

That can be achieved without such a lot of Makefile hackery, for example
with something like (untested):

ppc/check_altivec.o: CFLAGS := $(filter-out -maltivec,$(CFLAGS))

An appropriate comment would also be useful.

> --- ppc/imgresample_altivec.c	(revision 10492)
> +++ ppc/imgresample_altivec.c	(working copy)
> @@ -20,268 +20,12 @@
>  
>  /**
> - * @file imgresample.c
> - * High quality image resampling with polyphase filters .
> + * @file imgresample_altivec.c
> + * High quality image resampling with polyphase filters - altivec bits
>   */

Should be good to commit right away, but please spell AltiVec correctly.

> --- ppc/imgresample_altivec.h	(revision 0)
> +++ ppc/imgresample_altivec.h	(revision 0)
> @@ -0,0 +1,26 @@
> +/*
> + * Copyright (c) 2001 Fabrice Bellard. 

trailing whitespace

Also, is Fabrice the author of this code?  I don't think so, just remove
the line.

> --- ppc/check_altivec.c	(revision 10492)
> +++ ppc/check_altivec.c	(working copy)
> @@ -20,12 +20,12 @@
>  
> +/**
> + * @file check_altivec.c
> + * Checks for altivec presence.
> + */

see above

> --- ppc/util_altivec.h	(revision 10492)
> +++ ppc/util_altivec.h	(working copy)
> @@ -20,17 +20,14 @@
>  
> +/**
> + * @file util_altivec.h
> + * Contains misc utility macros and inline functions
> + */

see above

> --- dsputil.h	(revision 10492)
> +++ dsputil.h	(working copy)
> @@ -555,12 +555,6 @@
>  
> -#if defined(HAVE_ALTIVEC) && !defined(__APPLE_CC__)
> -#define pixel altivec_pixel
> -#include <altivec.h>
> -#undef pixel
> -#endif
> -

#ifdef removal is always a pleasure :)

Diego