[FFmpeg-devel] [PATCH] pointless #ifdeffery in mpegvideo_ppc.c
Tue Oct 2 14:15:14 CEST 2007
On Tue, Oct 02, 2007 at 12:54:28PM +0200, Diego Biurrun wrote:
> On Tue, Oct 02, 2007 at 12:30:12PM +0200, Diego Biurrun wrote:
> > On Tue, Oct 02, 2007 at 12:12:15PM +0200, Luca Barbato wrote:
> > > Diego Biurrun wrote:
> > > > On Tue, Oct 02, 2007 at 10:39:01AM +0200, Diego Biurrun wrote:
> > > >> This patch removes some pointless #ifdefs from
> > > >> libavcodec/ppc/mpegvideo_ppc.c and makes the file conditional on
> > > >> HAVE_ALTIVEC. It only contains AltiVec code anyway. Alternatively, or
> > > >> as a next step, it could be directly merged into mpegvideo_altivec.c.
> > >
> > > fine, I'm about to commit something more invasive about moving all
> > > altivec bits in the same place...
> > OK, I have committed my patch as a first step. Do you agree we should
> > move the code into mpegvideo_altivec.c now?
> Here is the patch. The ugly extern declarations could possibly be
> avoided by creating idct_altivec.h as a next step.
Approved by Luca on IRC, so applied.
More information about the ffmpeg-devel