[FFmpeg-devel] [PATCH] fix shifted picture in AMV video decoder when height is not dividable by 16

Michael Niedermayer michaelni
Fri Oct 12 00:40:59 CEST 2007

On Wed, Oct 10, 2007 at 09:34:07PM +0700, Vladimir Voroshilov wrote:
> Hi, All
> If picture height is not dividable by 16, AMV related flipping code in
> mjpeg decoder does not work correctly.
> You can easily see height%16 lines of garbage at the top of picture
> while the same number of bottom lines are not visible.
> Attached patch adds code which moves three YUV planes in buffer up
> after decoding picture.


> Comments and (especialy) optimizations are welcome.

a fix to the problem is welcome a memmove workaround is not

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071012/4e501bb6/attachment.pgp>

More information about the ffmpeg-devel mailing list