[FFmpeg-devel] [PATCH] DES en-/decryption
Sun Oct 14 11:29:21 CEST 2007
On Sun, Oct 14, 2007 at 09:05:03AM +0200, Reimar D?ffinger wrote:
> On Sun, Oct 14, 2007 at 02:05:36AM +0200, Aurelien Jacobs wrote:
> > On Sat, 13 Oct 2007 22:15:42 +0200
> > Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > --- libavutil/des.h (revision 0)
> > > +++ libavutil/des.h (revision 0)
> > > @@ -0,0 +1 @@
> > > +uint64_t ff_des_encdec(uint64_t in, uint64_t key, int decrypt);
> > I think you should add multiple inclusion protection.
> Why? As long as there are only function prototypes there should not be
> any reason to use them.
There are only function prototypes in the file *now*. But in the future
when something else gets added the probability of the multiple inclusion
guards being forgotten is quite high. The solution is to waste a few
bytes now and never worry about possible future bugs.
More information about the ffmpeg-devel