[FFmpeg-devel] [PATCH] Fix swapped colours for RGB555 and RGB565 in swscale

Michael Niedermayer michaelni
Sun Oct 28 00:12:08 CEST 2007


On Wed, Oct 24, 2007 at 03:48:00PM +0300, Kostya wrote:
> Looks like rgb1[56]toUV have color values swapped.
> Fixes roundup issue 162 and reported problem with 15-bit TSCC files.

this patch is TOTALLY wrong
it changes rgb1[56]toUV so they become identical to bgr1[56]toUV and at the
same time results in the corresponding luma functions to mismatch
which means that after this the output is _really_ wrong while before it
was merely switching red and blue

the actual bug seems to be that the function names of [rgb|bgr]1[56]to[UV|Y]
should be rgb<->bgr flipped
i also suspect that mplayers vf_scale.c might need a change to compensate for

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071028/5ae3ee38/attachment.pgp>

More information about the ffmpeg-devel mailing list