[FFmpeg-devel] [Patch] Better ash support (under OS/2?)
Mon Oct 29 10:01:21 CET 2007
Dave Yeo <daveryeo at telus.net> writes:
> Hi, Ash seems to be the most popular shell on OS/2 (as discussed on a
> different list). While ash runs configure fine the build fails due to
> broken include lines. This is due to this,
> echo "BUILD_ROOT=\"$PWD\"" >> config.mak
> Seems that $PWD is not set if $PWD was not set before invoking the
> shell and pwd or cd have not been executed. This simple patch would
That shell is broken. POSIX clearly states that PWD should always be
> also take care of the unlikely condition where the cached value of
> $PWD was wrong.
> Index: configure
> --- configure (revision 10870)
> +++ configure (working copy)
> @@ -916,6 +916,9 @@
> die "Out of tree builds are impossible with whitespace in source path."
> +# Make sure $PWD is current
> +pwd > /dev/null
Bad idea. Nothing mandates that running pwd have any effect on $PWD.
In fact, pwd may well be an external executable.
mans at mansr.com
More information about the ffmpeg-devel