[FFmpeg-devel] [PATCH] move av_crc04C11DB7_update to libavutil

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sun, Oct 28, 2007 at 10:11:05PM +0100, Baptiste Coudurier wrote:
>> Aurelien Jacobs wrote:
>> > Michael Niedermayer wrote:
>> > 
>> > 
>> >>Hi
>> >>
>> >>On Sun, Oct 28, 2007 at 06:51:19PM +0100, Baptiste Coudurier wrote:
>> >>
>> >>>Hi
>> >>>
>> >>>$subject. Needed to avoid code duplication for new ogg muxer.
>> >>
>> >>libavutil is not supposed to be a place for code common between libavcodec
>> >>and libavformat, even less so between 2 libavformat (de)muxers! but rather
>> >>a small lib of generally usefull things av_crc04C11DB7_update() is not
>> >>usefull outside of libavformat
>> >>
>> >>so this function should stay in libavformat 
>> 
>> Humm, so it ok to add it to aviobuf.c and avio.h for now ?
>
> yes

What sense does it make to have it in aviobuf.c?

> though maybe they should have a ff_ prefix to indicate that they are
> not part of the public API instead of av_

Yes.  IMHO, we should be more strict about following these naming
conventions.

-- 
M?ns Rullg?rd
mans at mansr.com