[FFmpeg-devel] seeking in ts (was: mpegvideo_parser outputs incomplete frames)

[Michael Niedermayer]

Hi

On Thu, Aug 30, 2007 at 10:16:57PM -0000, Wolfram Gloger wrote:
> Hi,
> 
> > both patches are ok if seeking in ts works as well as before the patch
> > (it should but well better someone checks ...)
> 
> Yes it should, but seeking in mpeg-ts is currently broken for me at
> least for frame copying, because first_dts isn't updated after a seek
> and that leads to oscillating timestamp problems.  Please consider the
> appended patch.

updated after a seek !?
what do you want to update, first_dts is the first dts, that doesnt change
after a seek

[...]

> @@ -1342,18 +1386,20 @@
>      st= s->streams[stream_index];
>  
>      /* first, we try the format specific seek */
> -    if (s->iformat->read_seek)
> -        ret = s->iformat->read_seek(s, stream_index, timestamp, flags);
> -    else
> -        ret = -1;
> +    if (!s->iformat->read_seek ||
> +	(ret = s->iformat->read_seek(s, stream_index, timestamp, flags)) < 0)
> +        ret = s->iformat->read_timestamp ?
> +	    av_seek_frame_binary(s, stream_index, timestamp, flags) :
> +	    av_seek_frame_generic(s, stream_index, timestamp, flags);

this is a unreadable mess and contains tabs


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070902/7f642864/attachment.pgp>