[FFmpeg-devel] [PATCH] AC3 decoder CRC check

Michael Niedermayer michaelni
Sun Sep 2 15:16:21 CEST 2007


On Sun, Sep 02, 2007 at 01:43:28PM +0100, M?ns Rullg?rd wrote:
> Andreas ?man <andreas at olebyn.nu> writes:
> > Hello,
> >
> > M?ns Rullg?rd wrote:
> >> That's not what the error resilience level is for.  This setting
> >> specifies how hard a decoder should try to cover up errors, not how
> >> to detect them.
> >
> > Hmm, okay
> > Any other ideas? A new struct member "error_detection_level", or a flag?
> >
> > I don't find anything thats currently there that would be appropriate.
> I reckon the decoder will notice if the frame is damaged anyway, and
> see no reason to explicitly check the CRC.

yes the patch makes no sense
but the ac3_probe code could benefit from checking the crcs...
that would also close https://roundup.mplayerhq.hu/roundup/ffmpeg/issue64


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070902/4838fa3f/attachment.pgp>

More information about the ffmpeg-devel mailing list