[FFmpeg-devel] [RFC][PATCH] Move H.264 intra prediction functions into their own context
Tue Sep 4 08:14:37 CEST 2007
On Mon, Sep 03, 2007 at 07:57:55PM +0200, Michael Niedermayer wrote:
> On Mon, Sep 03, 2007 at 03:48:46PM +0300, Kostya wrote:
> > There are two codecs based on H.264 drafts in lavc with slightly different
> > intra prediction functions - H.264 itself and SVQ3. As I was working on
> > RV30/40 and these codecs are based on H.264 drafts too with more different
> > intra prediction functions, I found it more convenient to move them into
> > separate context which is initialized with functions appropriate to chosen
> > codec (SVQ3 has two different prediction functions, RV40 a bit more).
> > So here is the patch to do this (while h264pred.[ch] were svn cp'ed out from h264.[ch] it is easier to send them plain).
> could you split the file in
> common ones
> h264 specific ones
> svq3 specific ones
> rv40 specific ones
> that way we can disable them at compile time nicely
No sense doing this for SVQ3 and separating other functions is a bit
tricky because of macros used (and I see no solution that would work
without some #ifdefs or unneeded visible functions).
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
More information about the ffmpeg-devel