[FFmpeg-devel] [PATCH] flicvideo.c, issue 123

Michael Niedermayer michaelni
Tue Sep 4 12:50:57 CEST 2007


On Mon, Sep 03, 2007 at 09:29:16PM -0700, Mike Melanson wrote:
> Hi,
> This patch addresses issue 123 in flicvideo.c. It's not the same
> one-liner fix as before since the decoder was still reading from invalid
> memory in the case of the 12-byte header.
> +    if (depth == 0) {
> +      depth = 8; /* Some FLC generators set depth to zero, when they mean 8Bpp. Fix up here */
> +    }

patch ok if you fix the indention of this

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070904/068d1f53/attachment.pgp>

More information about the ffmpeg-devel mailing list