[FFmpeg-devel] [PATCH] DNxHD/VC-3 encoder

[Diego Biurrun]

On Tue, Sep 04, 2007 at 07:39:46PM +0200, Baptiste Coudurier wrote:
> 
> Here is the encoder.
> 
> --- libavcodec/dnxhdenc.c	(revision 0)
> +++ libavcodec/dnxhdenc.c	(revision 0)
> @@ -0,0 +1,682 @@
> +/*
> + * VC3/DNxHD encoder.
> + * Copyright (c) 2007 Baptiste Coudurier <baptiste dot coudurier at smartjog dot com>.

nit: The periods are senseless.

> +    weigth_matrix = (n&2) ? ctx->cid_table->chroma_weigth : ctx->cid_table->luma_weigth;
> +
> +    for(i = 1; i < last_index; i++) {

for (

> --- libavformat/movenc.c	(revision 10288)
> +++ libavformat/movenc.c	(working copy)
> @@ -516,6 +516,51 @@
>  
> +/* also used by all avid codecs flavors (dv, imx, meridien) */

codec

Also, isn't it meridiAn?

> --- libavcodec/Makefile	(revision 10288)
> +++ libavcodec/Makefile	(working copy)
> @@ -358,6 +359,7 @@
>  OBJS-$(CONFIG_VP6_DECODER)             += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
>  OBJS-$(CONFIG_VP6F_DECODER)            += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
>  OBJS-$(CONFIG_SNOW_DECODER)            += i386/snowdsp_mmx.o
> +OBJS-$(CONFIG_DNXHD_ENCODER)           += i386/dnxhd_mmx.o
>  endif

This should be sorted.
  
> --- libavcodec/dnxhdenc.h	(revision 0)
> +++ libavcodec/dnxhdenc.h	(revision 0)
> @@ -0,0 +1,89 @@
> +/*
> + * VC3/DNxHD encoder.
> + * Copyright (c) 2007 Baptiste Coudurier <baptiste dot coudurier at smartjog dot com>.

ditto

> +#endif  // AVCODEC_DNXHDENC_H

Don't /* */ look that much nicer? ;-)

The build system part of the patch is OK, save for the nit above.

Diego