[FFmpeg-devel] [PATCH] cleanup allformats.h

[Aurelien Jacobs]

On Tue, 11 Sep 2007 00:14:13 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Mon, Sep 10, 2007 at 11:17:42PM +0200, Aurelien Jacobs wrote:
> > Hi,
> > 
> > The attached patch moves some function declarations out of allformats.h.
> > Those functions have nothing to do with this file.
> > 
> > Aurel
> > Index: libavformat/rtp.h
> > ===================================================================
> > --- libavformat/rtp.h	(revision 10473)
> > +++ libavformat/rtp.h	(working copy)
> > @@ -54,6 +54,8 @@
> >   */
> >  int rtp_check_and_send_back_rr(RTPDemuxContext *s, int count);
> >  
> > +void av_register_rtp_dynamic_payload_handlers(void);
> > +
> >  #define RTP_PT_PRIVATE 96
> >  #define RTP_VERSION 2
> >  #define RTP_MAX_SDES 256   /**< maximum text length for SDES */
> 
> as long as rtp.h is a installed header iam against adding anything to it

Indeed, you're right. Seeing the av_ prefix, I thought this was a public
function, but it seems it's really not. Maybe it should be renamed with
a ff_ prefix ?
Anyway, this declaration fits better in rtp_internal.h.

Now that I think about it, rtsp.h is also an installed header. So
redir_open() declaration really don't belong to it. This function
is declared extern just to support a "to be removed" hack in utils.c.
So I moved the declaration just inside this hack.

This new patch should be clean.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: allformats_cleanup.diff
Type: text/x-patch
Size: 5309 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070911/cea6d0c4/attachment.bin>