[FFmpeg-devel] [RFC] An improved implementation of ARMv5TE IDCT (simple_idct_armv5te.S)

Michael Niedermayer michaelni
Wed Sep 12 13:50:03 CEST 2007


On Wed, Sep 12, 2007 at 11:31:02AM +0300, Siarhei Siamashka wrote:
> Hello all,
> I have been working on improving IDCT performance for ARM for some time
> already and now think that it is more or less ready (performance wise) to 
> get accepted upstream:
> https://garage.maemo.org/plugins/scmsvn/viewcvs.php/trunk/libavcodec/armv4l/simple_idct_armv5te.S?root=mplayer&view=markup
> So now the question is: how it would be best to integrate this idct code 
> into ffmpeg? Should it replace the current simple_idct_armv5te.S file? 

yes if its always faster

> Could you please review the copyright part to check if it is ok?

is there anything special on it? it looks like normal LGPL

> I can provide a patch with omitted experimental prefetch code, all the globals
> getting 'ff_' prefix, use of 'ff_cropTbl' instead of keeping its own copy of
> cropping table 

patch welcome

> (by the way, it would be nice to extend MAX_NEX_CROP to 2048
> as idct can produce results in +-2K range when feeded with completely random
> data on input).

patch welcome

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070912/713da8d4/attachment.pgp>

More information about the ffmpeg-devel mailing list