[FFmpeg-devel] [PATCH] Re-add OS/2 support

[Diego Biurrun]

On Mon, Sep 10, 2007 at 10:03:40PM -0700, Dave Yeo wrote:
>
> I also just realized that make install was slightly broken when built with 
> --enable-shared. Updated patch included. (SLIB_INSTALL_EXTRA_CMD was 
> missing target and added SLIBNAME_WITH_VERSION).

I just applied the LN_S part.

> --- ffmpeg/configure	Sun Sep  9 00:01:48 2007
> +++ ffmpeg.os2/configure	Mon Sep 10 21:47:56 2007
> @@ -1196,6 +1199,27 @@
> +  os/2)
> +    LIBPREF=""
> +    LIBSUF="_s.lib"
> +    SLIBPREF=""
> +    SLIBSUF=".dll"
> +    SLIBNAME_WITH_VERSION='$(SLIBPREF)$(NAME)-$(LIBVERSION)$(SLIBSUF)'
> +    SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(NAME)-$(LIBMAJOR)$(SLIBSUF)'
> +    SLIB_EXTRA_CMD="dllar -o \$(NAME)\$(SLIBSUF) \$(NAME)\$(LIBSUF) -d \"\$(SLIBNAME_WITH_MAJOR)\" -omf -ord \$(LDFLAGS) \$(EXTRALIBS) \$(EXTRAOBJS); cp -f \$(SLIBNAME) \$(SLIBNAME_WITH_MAJOR)"
> +    SLIB_INSTALL_EXTRA_CMD="-install -m 644 \$(SLIBNAME:\$(SLIBSUF)=.lib) \$(SLIBNAME:\$(SLIBSUF)=.a) \$(LIBDIR)"

These two can be simplified by using single quotes.

> +    SLIB_INSTALL_EXTRA_CMD="-install -m 644 \$(SLIBNAME:\$(SLIBSUF)=.lib) \$(SLIBNAME:\$(SLIBSUF)=.a) \$(LIBDIR)"

This looks wrong.  First you set SLIBSUF to .dll then you change it
here?  What's going on?  Also, there should be no libs with the names
you are trying to install, since they are created under different names
according to what you have set LIBSUF and SLIBSUF to ...

Diego