[FFmpeg-devel] [RFC] Global or local variables in ffmpeg.c

Ramiro Polla ramiro
Sat Sep 15 21:14:52 CEST 2007


In [1], it was discussed whether variables passed to av_encode would be 
passed as arguments or used as globals.

Since the beginning of ffmpeg, they have been defined globals, are 
passed as arguments to av_encode, and av_encode uses the same local name 
as the global variables for them.

The arguments to av_encode are useless. Regression tests still pass for 

I'm trying to finish Limin Wang's work to split av_encode, but don't 
know which way to go.
Which way is preferable: making everything global variables and have 
parameter-less functions in ffmpeg.c, or passing something like 
AVTranscodeContext to av_encode and other functions?

Ramiro Polla

[1] http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/45222

More information about the ffmpeg-devel mailing list