[FFmpeg-devel] [PATCH] RV30/40 decoder

[Diego Biurrun]

On Mon, Sep 17, 2007 at 08:19:50AM +0300, Kostya wrote:
> On Sun, Sep 16, 2007 at 11:10:43PM +0200, Michael Niedermayer wrote:
> > 
> > On Sun, Sep 16, 2007 at 07:58:51PM +0300, Kostya wrote:
> > 
> > [...]
> > > +static int rv30_parse_slice_header(RV40DecContext *r, GetBitContext *gb, SliceInfo *si)
> > > +{
> > 
> > please split rv30 and rv40 into seperate files (rv30/rv40/common code) and
> > merge rv30/rv40 functions if they are nearly idenitcal
> 
> There are only two functions specific for RV30 - slice and macroblock type parsing.

It would still be preferable to have them in a separate file so that
they can be conditionally compiled.

Diego