[FFmpeg-devel] [PATCH] fix compiling VIS assembly on SPARC

Diego Biurrun diego
Sun Sep 23 23:56:29 CEST 2007

On Sun, Sep 23, 2007 at 11:58:11PM +0200, Balatoni Denes wrote:
> Sunday 23 September 2007 23:07-kor Diego Biurrun ezt ?rta:
> > > Unfortunatelly simple_idct_vis is compiled conditionally for ARCH_SPARC,
> > > and it doesn't depend on HAVE_VIS (however swscale/yuv2rgb_vis depends on
> > > HAVE_VIS), so without VIS it won't work (it won't even compile).
> >
> > The patch in question changes this.  All issues should have been
> > addressed by subsequent patches.  Reports about success or failure very
> > much welcome as I cannot test this code.
> Yes, sorry I only looked at Jan's patch now. It won't work because
> libavcodec/dsputil.c calls dsputil_init_vis if (ENABLED_SPARC) - this should 
> check for HAVE_VIS I guess. Otherwise - although I can not check right now - 
> it should work IMO.

Yes, good catch.  I have changed this along with another ARCH_SPARC test
in libavcodec/dsputil.h.

> Thanks for fixing this btw !

You are welcome.


More information about the ffmpeg-devel mailing list