[FFmpeg-devel] const abuse in rtp.c
Mon Sep 24 10:59:42 CEST 2007
I do not know what happened, but I see your email only today (while
it seems the email was sent on September 10)...
Sorry for the late reply
Romain DEGEZ wrote:
>>> Not having examined the code closely (and to be
>>> honest, it quite frightens me), I'm ready to believe that these uses
>>> of s->buf_ptr are mutually exclusive.
>> As far as I understand, the rtp_parse* or rtp_read* code should not even
>> touch the buf_ptr field. Or am I missing something?
> But quite frankly I sent this patch looooong time ago and my knowledge about
> all these are everything but fresh ...
> What I remember is that I wasn't satisfied at all by the way the whole rtp
> thing was implemented but my goal was to be able to read mp4/aac stream
> ASAP and rewriting all this code would have implied long and fastidious
> exchanges with Michael (as noone was really interested in the rtp/rtsp part
> of ffmpeg at this time), something I wasn't brave enough to face :-)
> Feel free to change/alter/modify/delete/whatever....
Ok, today I'll remove the suspect line of code (line 693 in libavformat/rtp.c).
I believe this will fix the warning without introducing any regression...
Anyway, if I am wrong people will complain
More information about the ffmpeg-devel